Skip to content

Merge rewards files #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 25, 2025
Merged

Merge rewards files #68

merged 5 commits into from
Aug 25, 2025

Conversation

DNXie
Copy link
Member

@DNXie DNXie commented Aug 25, 2025

  • Merge rewards files into one file rewards.py

Test:

(forge-8e46c2a) ➜  forge git:(merge_rewards) ✗ python forge/tests/unit_tests/rl/test_math_reward.py
..........................
----------------------------------------------------------------------
Ran 26 tests in 0.002s

OK
(forge-8e46c2a) ➜  forge git:(merge_rewards) ✗ python forge/tests/unit_tests/rl/test_thinking_reward.py
................
----------------------------------------------------------------------
Ran 16 tests in 0.000s

OK
W0825 13:58:07.499392 3444073 ThreadLocalStats-inl.h:523] Deleting parent container while 13 stats are registered:
W0825 13:58:07.499955 3444063 ThreadLocalStats-inl.h:523] Deleting parent container while 16 stats are registered:
W0825 13:58:07.500263 3444076 ThreadLocalStats-inl.h:523] Deleting parent container while 3 stats are registered:
W0825 13:58:07.500535 3444074 ThreadLocalStats-inl.h:523] Deleting parent container while 2 stats are registered:

@DNXie DNXie requested a review from pbontrager August 25, 2025 21:01
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 25, 2025
@DNXie DNXie merged commit 1a7dd9a into meta-pytorch:main Aug 25, 2025
4 checks passed
@DNXie DNXie mentioned this pull request Aug 25, 2025
Merged
@DNXie DNXie deleted the merge_rewards branch September 10, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbontrager pbontrager pbontrager approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DNXie @pbontrager